Re: [PATCH] lib/string: avoid reading beyond src buffer in strscpy
Linus Torvalds writes: (Summary) No, strnlen_user() definitely does too. No, strnlen_user() definitely does too. It's just that KASAN doesn't track user pointers. It's just that KASAN doesn't track...
View ArticleRe: linux-next: error while fetching the spi-nor tree
Linus Torvalds writes: (Summary) I don't know what infradead.org does, but you can definitely do bad things maintaining a git tree. maintaining a git tree. I would suggest doing a force-push back to...
View ArticleRe: Linux 4.15-rc2: Regression in resume from ACPI S3
Linus Torvalds writes: On Wed, Dec 13, 2017 at 8:41 AM, Thomas Gleixner <tglx@linutronix.de> wrote: [...] out what now causes that spurious interrupt to surface out of the blue. Perhaps just...
View ArticleRe: [patch 05/16] mm: Allow special mappings with user access cleared
Linus Torvalds writes: (Summary) On Wed, Dec 13, 2017 at 7:54 AM, Peter Zijlstra <peterz@infradead.org> wrote: [...] What use are protection keys if you can trivially circumvent them? No, we will...
View ArticleRe: Long live %pK (was Re: [PATCH tip/core/rcu 02/20] torture: Pre ...
Linus Torvalds writes: (Summary) Not the total idiocy that was %pK that never resulted in any actual improvement anywhere. resulted in any actual improvement anywhere.[...] approach to security....
View ArticleRe: [patch 05/16] mm: Allow special mappings with user access cleared
Linus Torvalds writes: (Summary) It's literally extra complexity for no actual real gain, and there is a real downside: the extra complexity that will cause people to get things wrong. that will cause...
View ArticleRe: [patch 05/16] mm: Allow special mappings with user access cleared
Linus Torvalds writes: (Summary) On Wed, Dec 13, 2017 at 10:32 AM, Peter Zijlstra <peterz@infradead.org> wrote: [...] already disallows read(2) from writing to them. So I don't mind at all the...
View ArticleRe: [PATCH] Fix resume on x86-32 machines
Linus Torvalds writes: (Summary) wrote: [...] the cleanups / nicer fixes sometime later? The fix patch was already posted, but in another thread (confusingly with _almost_ the same subject: "Re: Linux...
View ArticleRe: BUG: unable to handle kernel paging request in __switch_to
Linus Torvalds writes: (Summary) wrote: [...] you dice it, int3 is a benign exception. That just means that it doesn't double-fault when it takes the page fault. Which we already know, because we see a...
View ArticleRe: [PATCH v2 11/17] selftests/x86/ldt_gdt: Prepare for access bit ...
Linus Torvalds writes: (Summary) And that's a requirement regardless, because no way in hell should users be able to read the damn thing. damn thing. So it clearly needs to have the PAGE_USER bit clear...
View ArticleRe: [PATCH v2 11/17] selftests/x86/ldt_gdt: Prepare for access bit ...
Linus Torvalds writes: (Summary) On Thu, Dec 14, 2017 at 1:44 PM, Linus Torvalds<torvalds@linux-foundation.org> wrote:[...] that we can't do get_user/put_user on it. Actually, just clearing...
View ArticleRe: [PATCH v2 11/17] selftests/x86/ldt_gdt: Prepare for access bit ...
Linus Torvalds writes: (Summary) On Thu, Dec 14, 2017 at 2:02 PM, Peter Zijlstra <peterz@infradead.org> At least the old get_user_pages_fast() code used to check the USER bit: At least the old...
View ArticleRe: [PATCH v2 11/17] selftests/x86/ldt_gdt: Prepare for access bit ...
Linus Torvalds writes: (Summary) On Thu, Dec 14, 2017 at 2:11 PM, Andy Lutomirski <luto@amacapital.net> wrote: [...] That seems to rather defeat the point of using a VMA, though. There never was...
View ArticleRe: Linux 4.15-rc2: Regression in resume from ACPI S3
Linus Torvalds writes: On Thu, Dec 14, 2017 at 2:36 PM, Thomas Gleixner <tglx@linutronix.de> wrote: [...] think it's the firmware which causes it by unmasking the PIC irqs. Yes, that sounds quite...
View ArticleRe: [PATCH v2 11/17] selftests/x86/ldt_gdt: Prepare for access bit ...
Linus Torvalds writes: (Summary) wrote: [...] say? I don't think they are secret, it's more of a "if they can read it, they can write it" kind of thing. they can write it" kind of thing. The whole "it...
View ArticleRe: [PATCH v2 11/17] selftests/x86/ldt_gdt: Prepare for access bit ...
Linus Torvalds writes: (Summary) wrote: [...] foreign mm. That sounds wrong. That sounds wrong. We actually had some very serious reasons why get_user_pages_fast() needed to check access_ok(). needed...
View ArticleRe: [PATCH urgent 0/3] __restore_processor_state() fixes
Linus Torvalds writes: On Thu, Dec 14, 2017 at 5:28 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: [...] Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> And I'm assuming I'll get...
View ArticleRe: [GIT PULL] Staging driver fixes for 4.15-rc4
Linus Torvalds writes: (Summary) On Fri, Dec 15, 2017 at 11:00 AM, Greg KH <gregkh@linuxfoundation.org> wrote: [...] patch got reverted due to build errors reported by 0-day. Since the revert was...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) Also, while I think we *should* check the PAGE_USER bit when walking the page tables, like we used to, we should the page tables, like we used to, we should (a) do it...
View ArticleRe: [PATCH v2 01/17] mm/gup: Fixup p*_access_permitted()
Linus Torvalds writes: (Summary) We'd have to do something like put the !PAGE_USER mapping at the top of the user address space, and then simply make user_addr_max() smaller than the actual user page...
View Article