Quantcast
Channel: lkml.org : Vaidyanathan Srinivasan
Viewing all articles
Browse latest Browse all 890

Re: [tip:locking/core] locking/atomics: Simplify the op definition ...

$
0
0
Linus Torvalds writes: (Summary) Probably better than having i/I.
Probably better than having i/I.
But while people are bikeshedding the important stuff, can I please mention my personal pet peeve with generated code?
my personal pet peeve with generated code?
If we go down this "generate header files" path, and ever expand to actually generating some of the definitions too, can we *please* try to follow three rules:
follow three rules:
(a) make the generated header file not just say "this is generated", but say exactly *what* generates it, so that when you look at it, you don't have to search for the generator?
have to search for the generator?
(b) if at all possible, please aim to make "git grep" find the stuff that is generated?
is generated?
(c) if b is not possible, then generate '#line' things in the generator so that debug information points back to the original source?

Viewing all articles
Browse latest Browse all 890

Trending Articles