Linus Torvalds writes: (Summary) Looks good to me.
Looks good to me.
At the risk of bike-shedding, we could remove all the At the risk of bike-shedding, we could remove all the default 1 if !SMP
default 1 if !SMP
from the BEGIN/END/DEFAULT things, and perhaps just keep that part in NR_CPUS. !MAXSMP range NR_CPUS_RANGE_BEGIN NR_CPUS_RANGE_END
default "1" if !SMP
default NR_CPUS_DEFAULT
default NR_CPUS_DEFAULT
but maybe the "range" line would need an "if !SMP" on it too to avoid the issue with "1" being out of range.,
the issue with "1" being out of range.,
That would still leave the NR_CPUS thing *much* easier to understand, and it would mean that the other helper things wouldn't need to care about the UP case.
about the UP case.
But regardless, that least version looks perfectly fine to me even without that random tweak.
without that random tweak.
Linus
Linus
Linus
Looks good to me.
At the risk of bike-shedding, we could remove all the At the risk of bike-shedding, we could remove all the default 1 if !SMP
default 1 if !SMP
from the BEGIN/END/DEFAULT things, and perhaps just keep that part in NR_CPUS. !MAXSMP range NR_CPUS_RANGE_BEGIN NR_CPUS_RANGE_END
default "1" if !SMP
default NR_CPUS_DEFAULT
default NR_CPUS_DEFAULT
but maybe the "range" line would need an "if !SMP" on it too to avoid the issue with "1" being out of range.,
the issue with "1" being out of range.,
That would still leave the NR_CPUS thing *much* easier to understand, and it would mean that the other helper things wouldn't need to care about the UP case.
about the UP case.
But regardless, that least version looks perfectly fine to me even without that random tweak.
without that random tweak.
Linus
Linus
Linus