Re: [GIT PULL] inode->i_version rework for v4.16

Linus Torvalds writes: (Summary) And I require people to *think* about it.
people to *think* about it.
So what's to horribly horribly wrong?
So what's to horribly horribly wrong?

The inode_cmp_iversion{+raw}() functions are pure and utter crap. They return that ternary value as the
sequence number difference in a 's64', which means that if you
actually care about that ternary value, and do the *sane* thing that
the kernel-doc of the function implies is the right thing, you would
do

    int cmp = inode_cmp_iversion(inode, old); That way
there is no worry about uses, and if somebody *really* cares about the
ternary value, they can now use a "switch" statement to get it
(alternatively, make it return an enum, but whatever).