Re: [lkp-robot] [x86/asm] 51bad67ffb: int3:#[##]
Linus Torvalds writes: (Summary) On Tue, May 15, 2018 at 3:43 PM Josh Poimboeuf <jpoimboe@redhat.com> wrote: On Tue, May 15, 2018 at 3:43 PM Josh Poimboeuf <jpoimboe@redhat.com> Do we have...
View ArticleRe: [lkp-robot] [x86/asm] 51bad67ffb: int3:#[##]
Linus Torvalds writes: (Summary) Side note: doing some grepping, I find some other sequences that are a bit scary, like this: scary, like this: arch/x86/kernel/acpi/wakeup_32.S-.data...
View ArticleRe: [PATCH] vsprintf: Fix memory barriers of ptr_key to have_filed ...
Linus Torvalds writes: (Summary) On Tue, May 15, 2018 at 4:00 PM Steven Rostedt <rostedt@goodmis.org> wrote: On Tue, May 15, 2018 at 4:00 PM Steven Rostedt <rostedt@goodmis.org> wrote:...
View ArticleRe: [PATCH v2] x86/asm: Pad assembly functions with INT3 instructions
Linus Torvalds writes: (Summary) It looks local to entry_32.S, and should look like restore_all rather than resume_userspace. restore_all rather than resume_userspace. So we probably should remove the...
View ArticleRe: Fw: [PATCHSET] workqueue: Show the latest workqueue name in /p ...
Linus Torvalds writes: (Summary) We're already talking to the procps-ng people exactly because of this. because of this. That said, nobody actually mis-parses anything or overflows any buffers (you'd...
View ArticleRe: [PATCH] proc: Don't allow empty /proc/PID/cmdline for user tasks
Linus Torvalds writes: (Summary) } -static ssize_t proc_pid_cmdline_read(struct file *file, char __user *buf, - size_t _count, loff_t *pos) +static ssize_t get_mm_cmdline(struct mm_struct *mm, char...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) header file that has these kinds of macros (or "pseudo-instructions") for assembly language cases, and then we could just rely on them in inline asm. could just rely on...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) Particularly since it's probably just one specific list where you want this oddly specific behavior. list where you want this oddly specific behavior. Also, if we...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: On Fri, May 18, 2018 at 10:24 AM Nadav Amit <namit@vmware.com> wrote: On Fri, May 18, 2018 at 10:24 AM Nadav Amit <namit@vmware.com> wrote: [...] =E2=80=9D...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 11:34 AM <hpa@zytor.com> We already do something like that for real *.S files on some architectures (because their assembly really wants...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) And yes, like hpa says, we should make sure that behavior is acknowledged by the GNU as people, so that they then don't come back and say "hey, now we assemble things...
View ArticleRe: [PATCH 2/6] x86: bug: prevent gcc distortions
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 12:18 PM Nadav Amit <namit@vmware.com> wrote: On Fri, May 18, 2018 at 12:18 PM Nadav Amit <namit@vmware.com> The source program is...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 8:15 PM Vasily Gorbik <gor@linux.ibm.com> wrote: On Fri, May 18, 2018 at 8:15 PM Vasily Gorbik <gor@linux.ibm.com> If proc doesn't...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) I was going to point to the s_maxbytes check in rw_verify_area() and ask you how that ever worked for that file, but it's not there, the s_maxbyte checks are only in...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index a45f0af22a60..83278c547127 100644 --- a/fs/proc/vmcore.c +++...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) On Fri, May 18, 2018 at 9:12 PM Linus Torvalds < wrote:[...] superblock"). Actually, maybe we could just make rw_verify_area() use the new file_mmap_size_max()...
View ArticleRe: [PATCH] procfs: fix mmap() for /proc/vmcore
Linus Torvalds writes: (Summary) wrote: [...] so, as it is this patch does not fix the issue. Right you are. Right you are. We could easily reverse the order of those two checks, but since clearly the...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) The whole chain to look up the pointer you are taking 'next' of needs to be under RCU, and that's not clear from your example. 'next' of needs to be under RCU, and...
View ArticleRe: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
Linus Torvalds writes: (Summary) Once we get to "take the next entry, but skip it if it's the head entry, and then return NULL if you get back to the entry you started with" kind of semantics, an...
View ArticleRe: [GIT PULL] Btrfs fixes for 4.17-rc6
Linus Torvalds writes: (Summary) On Sun, May 20, 2018 at 8:21 AM David Sterba <dsterba@suse.com> Especially with the tree-log.c changes being fairly big, I took a look, and I have to say that I...
View Article
